Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ap/ibc v2 to v4 #3422

Merged
merged 14 commits into from
Oct 31, 2023
Merged

Ap/ibc v2 to v4 #3422

merged 14 commits into from
Oct 31, 2023

Conversation

snobbee
Copy link
Contributor

@snobbee snobbee commented Oct 27, 2023

  • IBC go migration from v2 to v4
  • and Cosmos SDK upgrade from v0.45.9 to v0.45.16

This was referenced Oct 27, 2023
Closed
Closed
This was referenced Oct 27, 2023
Closed
Closed
Closed
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #3422 (b846644) into master (0c63583) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 30.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3422   +/-   ##
=======================================
  Coverage   43.35%   43.36%           
=======================================
  Files         166      166           
  Lines       15895    15904    +9     
=======================================
+ Hits         6891     6896    +5     
- Misses       8591     8595    +4     
  Partials      413      413
Files Coverage Δ
app/app.go 90.20% <100.00%> (+0.10%) ⬆️
cmd/sifnoded/cmd/ibc-diag.go 15.74% <ø> (ø)
x/dispensation/types/types.go 100.00% <100.00%> (ø)
x/ibctransfer/helpers/conversion_helper.go 37.19% <ø> (ø)
x/ibctransfer/keeper/msg_server.go 86.95% <ø> (ø)
x/ibctransfer/types/mocks/expected_keepers_gen.go 25.33% <ø> (ø)
app/setup_handlers.go 10.52% <0.00%> (+1.83%) ⬆️
x/ibctransfer/onrecv_packet.go 0.00% <0.00%> (ø)
x/tokenregistry/types/mock/keeper_gen.go 0.00% <0.00%> (ø)

@snobbee snobbee requested review from khdegraaf and removed request for khdegraaf October 31, 2023 03:39
@snobbee snobbee merged commit 51b0ceb into master Oct 31, 2023
7 checks passed
@snobbee snobbee deleted the ap/ibc-v2-to-v4 branch October 31, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgoos pgoos pgoos approved these changes

@jzvikart jzvikart Awaiting requested review from jzvikart

@khdegraaf khdegraaf Awaiting requested review from khdegraaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snobbee @pgoos @atheeshp